Cleanup obsolete dependencies and polyfills #174
Conversation
- Removed `core-js` and `regenerator-runtime` as explicit imports in `src`. The library targets ES2015+ (as per tsconfig) and modern environments. Polyfilling should be handled by the consumer or build tool configuration if needed, not hardcoded in the library source. - Removed unused devDependencies: `@eslint/js`, `eslint-define-config`. - Added `lint` and `type-check` scripts to `package.json`. - Enabled `skipLibCheck` in `tsconfig.json` to resolve type errors in `node_modules` exposed by the environment changes. - Verified changes with `npm run lint`, `npm run type-check`, `npm test` (unit/integration/visual), and `npm run build`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR removes obsolete dependencies and polyfills to clean up the project and reduce bundle size/complexity.
Removals:
core-js: Removed imports fromsrc/visualizations/heatmap/Heatmap.ts,src/visualizations/sunburst/Sunburst.tsand their declaration files. Uninstalled the package.regenerator-runtime: Removed imports from the same files and uninstalled.@eslint/js: Uninstalled (identified as unused).eslint-define-config: Uninstalled (identified as unused).Configuration Changes:
lint(eslint .) andtype-check(tsc --noEmit) scripts topackage.json."skipLibCheck": truetotsconfig.jsonto handle pre-existing type errors innode_modules.Verification:
npm run lint: Passed.npm run type-check: Passed.npm test: All tests passed (including visual regression tests using puppeteer).npm run build: Successful.PR created automatically by Jules for task 5574598873554789779 started by @pverscha