Skip to content

Conversation

@google-labs-jules
Copy link

Memoize recursive color calculation in Sunburst visualization to improve rendering performance.


PR created automatically by Jules for task 423510718466607053 started by @pverscha

This commit optimizes the `Sunburst` visualization by memoizing the recursive color calculation.

Previously, `color(node)` would recursively visit all children to compute the average color. Since `color` is called for every rendered node (and recursively for their children), this resulted in O(N*visible_nodes) complexity, causing redundant traversals.

The optimization caches the computed color in `node.extra.computedSunburstColor`. This reduces the complexity to O(N) for the initial traversal and O(1) for subsequent lookups.

Benchmark results showed a reduction from ~0.65ms per call (amortized over 1000 calls) to ~0.00013ms per call, a massive speedup for repeated rendering or interaction.

Existing tests passed.
Reverted unintended package-lock.json changes.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants