Metadata Hook Template #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smak0v instead of adding a new hook, can we just add HookMetadata to |
…hMetadata is removed, tests are updated
|
@saucepoint The Counter hook is now extended to support HookMetadata |
|
sg, i can take over the PR and refix the dependency once v4-periphery has HookMetadata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to provide a basic implementation example of the Uniswap V4 hook with metadata support. This code is based on the opened PR to the
v4-peripheryrepository.NOTE: the
.gitmodulesfile was updated as well to look into thev4-peripheryfork with the required HookMetadata abstract contract. We will update it back as soon as the mentioned above PR will be merged into the originalv4-peripheryrepository.