Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cosenal
requested changes
May 14, 2025
Yeah, let's just remove the line. Removed in e4dc69c. |
cosenal
reviewed
May 15, 2025
metriq-api/index.js
Outdated
| @@ -1,4 +1,8 @@ | |||
| process.env.METRIQ_MODE = undefined | |||
|
|
|||
| function sanitizeConnectionString(connectionString) { | |||
There was a problem hiding this comment.
Then we don't need this anymore
cosenal
approved these changes
May 15, 2025
cosenal
pushed a commit
that referenced
this pull request
May 15, 2025
…nsitive information (#255) * Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: remove console log statement. * chore: remove sanitize function --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/unitaryfoundation/metriq-api/security/code-scanning/1
To fix the issue, we need to ensure that sensitive information, such as the database password, is not logged. Instead of logging the full connection string, we can log a sanitized version that excludes sensitive details. This can be achieved by constructing a version of the connection string that omits the password before logging it.
The fix involves:
metriq-api/index.jsto log a sanitized version ofconfig.pgConnectionString.Suggested fixes powered by Copilot Autofix. Review carefully before merging.