Skip to content

Conversation

@unixorn
Copy link
Owner

@unixorn unixorn commented Oct 1, 2025

Description

If fzf was installed by brew, the completions and keybindings files are in $(brew --prefix fzf)/shell, so source them from there instead of $FZF_PATH/shell

Checklist

  • All new and existing tests pass.
  • Rather than adding functions to fzf-zsh-plugin.zsh, I have created standalone scripts in bin so they can be used by non-ZSH users too.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

If fzf was installed by `brew`, the completions and keybindings files
are in `$(brew --prefix fzf)/shell`, so source them from there.

Signed-off-by: Joe Block <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 1.19s
⚠️ REPOSITORY checkov yes 2 no 18.43s
✅ REPOSITORY devskim yes no no 1.51s
✅ REPOSITORY dustilock yes no no 0.0s
✅ REPOSITORY gitleaks yes no no 0.42s
✅ REPOSITORY git_diff yes no no 0.04s
✅ REPOSITORY grype yes no no 32.59s
⚠️ REPOSITORY kics yes 2 no 1.62s
✅ REPOSITORY secretlint yes no no 1.08s
✅ REPOSITORY syft yes no no 3.33s
✅ REPOSITORY trivy yes no no 8.08s
✅ REPOSITORY trivy-sbom yes no no 0.2s
✅ REPOSITORY trufflehog yes no no 3.86s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@unixorn unixorn merged commit 0024a87 into main Oct 1, 2025
6 checks passed
@unixorn unixorn deleted the fix-brew-issue branch October 1, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants