feat(loader): support validate with standard schema
#237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ysknsid25 <[email protected]>
pi0
reviewed
Mar 26, 2025
pi0
changed the title
validate with standard schema
Signed-off-by: ysknsid25 <[email protected]>
Member
|
@ysknsid25 i will put more time on this PR before releasing in next minor releases. It is a big feature! |
pi0
reviewed
Jul 30, 2025
| await expect( | ||
| loadConfig({ | ||
| configFile: "CUSTOM", | ||
| it("load fixture config with validate for zod - toThrow", async () => { |
Member
There was a problem hiding this comment.
We have many new tests. As this feature is based on standard schema, validating against one of them is enough to make maintenance easier
pi0
reviewed
Jul 30, 2025
package.json
Outdated
| "test:types": "tsc --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "@standard-schema/spec": "^1.0.0", |
Member
There was a problem hiding this comment.
We can copy-paste types (as they suggest) to avoid extra dependency
pi0
reviewed
Jul 30, 2025
| configFileRequired?: boolean; | ||
|
|
||
| schema?: S; | ||
| validate?: (schema: S, input: ResolvedConfig<T, MT>) => void; |
Member
There was a problem hiding this comment.
Thinking how we could make it simpler. Like setting a schema could be enough (to also cover validate + schema transform)
Contributor
Author
There was a problem hiding this comment.
StandardSchema already has vendor and validate, so it looks like we can look at vendor and isolate the call to validate 👍
Give me more time 🙏
Signed-off-by: ysknsid25 <[email protected]>
define StandardSchema Signed-off-by: ysknsid25 <[email protected]>
define StandardSchema Signed-off-by: ysknsid25 <[email protected]>
define StandardSchema Signed-off-by: ysknsid25 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempts to resolve #228