Skip to content

Conversation

@kricsleo
Copy link
Member

resolves #54

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@8b0a277). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage        ?   96.64%           
=======================================
  Files           ?        8           
  Lines           ?      149           
  Branches        ?       29           
=======================================
  Hits            ?      144           
  Misses          ?        5           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0
Copy link
Member

pi0 commented Apr 3, 2025

Thanks for PR and sharing benchmark.

Keeping references in local scope of package makes it not working if there are two versions of confbox used (can be same version but in different places even like one bundled) also init of map in outside makes treeshaking harder.

While both solvable, I think considering there is no significant difference in perf it is better to not do this.

@pi0 pi0 closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use WeakMap to store/retrieve the format.

2 participants