Skip to content

GitHub Actions: Test on current versions of Node.js #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

GitHub Actions: Test on current versions of Node.js #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@ on:

jobs:
ci:
strategy:
fail-fast: false
matrix:
node-version: ['18.x', '20.x', 'lts/*']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18.x is EOL..

Copy link
Author

@cclauss cclauss Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still one more week, but we can drop it. https://nodejs.org/en/blog/release/v18.20.8

Suggested change
node-version: ['18.x', '20.x', 'lts/*']
node-version: ['20.x', 'lts/*']

Should we add latest or just focus on LTS versions?

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: ${{ matrix.os }}
cache: "pnpm"
- run: pnpm install
- run: pnpm lint
Expand Down