-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add support for package.json5 and package.yaml formats #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 89.40% 91.08% +1.68%
==========================================
Files 5 10 +5
Lines 434 314 -120
Branches 37 72 +35
==========================================
- Hits 388 286 -102
+ Misses 46 28 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for PR! It would be nice if we could merge them also into one simple util like findPackage(), readPackage(), .. this way users can simply use one standard util to support all possible formats (bun for instance allows jsonc for package.json) |
If I understand correctly, merging the existing functions ( |
thats why i suggested to use new readPackage (vs current readPackageJSON) — also for new formats we could merge them directly to it to reduce confusion with many exported utils. |
I misunderstood you at first, feel free to review now |
closes #227 :)