You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance Azure drivers to support user-assigned managed identity authentication by adding an optional managedIdentityClientId parameter. This allows choosing the correct user assigned managed identity to use.
Changes:
Added managedIdentityClientId option to driver interfaces to use with DefaultAzureCredential if provided
Improved authentication flexibility for Azure services
Fixing a bug with CosmosDB syntax that changed that didn't came up due to disabled test suites
Fixed removeItem throws in CosmosDB driver
Improved stability of Key Vault and it's test suite by introducing a wait of 750ms (average time to purge) only after clean if purge is provided
Added a parameter to disablePurging for Key Vaults with enabled purge protection
All changes are tested against the local emulator (if available) and live Azure resources.
Appreciate the PR but please consider splitting changes next times, it is clearly written in PR template.
Please keep your changes minimal and split them if you need to.
I can of course split this, the errors just occured "on accident" when running the test suites and for the changes to be validated properly, I needed the test suites to be representative.
It's no problem to split out the the fixes separately if you want, just wanted to save you the review work :)
The reason will be displayed to describe this comment to others. Learn more.
Cannot we simply use this? Is new DefaultAzureCredential({}) and ``new DefaultAzureCredential({ managedIdentityClientId:undefined })` behavior different?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Azure drivers to support user-assigned managed identity authentication by adding an optional
managedIdentityClientIdparameter. This allows choosing the correct user assigned managed identity to use.Changes:
managedIdentityClientIdoption to driver interfaces to use with DefaultAzureCredential if providedremoveItemthrows in CosmosDB drivercleanif purge is providedAll changes are tested against the local emulator (if available) and live Azure resources.