Skip to content

feat: support getItem(key, { type }) #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jlucaso1
Copy link
Contributor

@jlucaso1 jlucaso1 commented Apr 7, 2025

Implements #528

@jlucaso1 jlucaso1 requested a review from pi0 as a code owner April 7, 2025 03:35
@jlucaso1 jlucaso1 requested a review from pi0 April 7, 2025 16:37
@pi0 pi0 changed the title feat(storage): enhance get() method to support multiple data types feat: support getItem(key, { type }) Apr 10, 2025
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 74.57627% with 15 lines in your changes missing coverage. Please review.

Project coverage is 59.50%. Comparing base (70310f9) to head (3fcff8f).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/storage.ts 74.57% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   59.99%   59.50%   -0.49%     
==========================================
  Files          42       42              
  Lines        3657     3823     +166     
  Branches      590      618      +28     
==========================================
+ Hits         2194     2275      +81     
- Misses       1460     1544      +84     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jlucaso1 jlucaso1 requested a review from pi0 April 10, 2025 19:30
@pi0
Copy link
Member

pi0 commented Apr 13, 2025

After pushed some simplification refactors (5b020ec) i noticed there are cases we don't cover (for example blob to bytes) and cases we cover but without best perf (for example blob can be constructed from string and also directly converted to an stream).

Thinking to migrate to undio

@jlucaso1
Copy link
Contributor Author

@pi0 The last commit is an attempt of migrate to undio. Can you review again?

@jlucaso1 jlucaso1 requested a review from pi0 April 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants