-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Adjust progress bar behavior #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-river-0087b630f-971.eastus2.1.azurestaticapps.net |
805009f
to
0a92eee
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-river-0087b630f-971.eastus2.1.azurestaticapps.net |
// setting the max progress to 100 instead and initially target 50 | ||
// When total number of resources increases, we always increase the target by half of the remainder to 100 | ||
// Usually the total grows several times, so ultimately the progress will appear as converging to completion. | ||
if (this._previousTotalResources != totalResources) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the number of resources is less than 100, or that the number of total resources stops changing (because the number of total files is the final one), the progress bar will stop updating, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is not completely ideal, but neither is the current jumping back and forth... Like this it feels a bit more reflective of the actual loading progress. Alternatively we could have the progress bar/progress ring as indeterminate and maybe show the number of loaded resources as text. Not sure if that would be better? Quick mockup:
Trying out the UX of fixed total number of resources