Skip to content

feat: Adjust progress bar behavior #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MartinZikmund
Copy link
Member

Trying out the UX of fixed total number of resources

Copy link

github-actions bot commented May 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-river-0087b630f-971.eastus2.1.azurestaticapps.net

@MartinZikmund MartinZikmund marked this pull request as ready for review May 20, 2025 11:26
@MartinZikmund MartinZikmund force-pushed the dev/mazi/progressbar-adjust branch from 805009f to 0a92eee Compare May 20, 2025 11:27
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-river-0087b630f-971.eastus2.1.azurestaticapps.net

// setting the max progress to 100 instead and initially target 50
// When total number of resources increases, we always increase the target by half of the remainder to 100
// Usually the total grows several times, so ultimately the progress will appear as converging to completion.
if (this._previousTotalResources != totalResources)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the number of resources is less than 100, or that the number of total resources stops changing (because the number of total files is the final one), the progress bar will stop updating, right?

Copy link
Member Author

@MartinZikmund MartinZikmund Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not completely ideal, but neither is the current jumping back and forth... Like this it feels a bit more reflective of the actual loading progress. Alternatively we could have the progress bar/progress ring as indeterminate and maybe show the number of loaded resources as text. Not sure if that would be better? Quick mockup:

Screen.Recording.2025-06-06.145810.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants