fix: Register ViewMap types when RouteMap is inserted into RouteRegistry #2986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What is the current behavior?
When ViewMaps are registered via RouteMap during navigation setup:
The
ViewMap.RegisterTypes()method is never called becauseRouteRegistrydoesn't overrideInsertItem(). ViewModels remain unregistered in the DI container, causingDataContextto be null on first navigation. After Hot Reload, the service provider rebuilds and ViewMaps are re-registered through a different path, masking the issue.What is the new behavior?
RouteRegistry.InsertItem()now:ViewMap.RegisterTypes()to register View and ViewModel types in DIViewModels are properly registered during app startup and available for DataContext assignment on first navigation.
PR Checklist
Screenshots Compare Test Runresults.Other information
Testing: Added 10 unit tests including bug reproduction test that fails without fix and passes with it. All 11 navigation tests pass with no regressions.
Impact: Low risk - only affects registration during app startup. No breaking changes.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
1oavsblobprodcus350.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E8B33609F82B4D2DB59C009A9FC7A4C1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force eql-�� deql-scratch/dbs/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackabash ess/TestBackend//p:DisableImplicitNuGetFallbackFolder=true nfig/composer/ve--verbosity ing/packages(dns block)2kmvsblobprodcus39.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/70593C6D7716240F283A24747D312FA1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)37cvsblobprodcus359.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/2F791F74279429A4411827997DA8D4D6/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)4myvsblobprodcus32.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/70593C6D7716240F283A24747D312FA1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)96bvsblobprodcus338.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/70593C6D7716240F283A24747D312FA1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)crl.godaddy.com/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/070F606598054205578256E76ACC5529/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/7C413E517467CDB6A87A0AA3E5D24D5A/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force 4d-a��(dns block)dlbvsblobprodcus316.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E7B5E0C97290FB53C2DCA420CF493E2A/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)e7bvsblobprodcus348.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/70593C6D7716240F283A24747D312FA1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/2F791F74279429A4411827997DA8D4D6/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E8B33609F82B4D2DB59C009A9FC7A4C1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force eql-�� deql-scratch/dbs/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackabash ess/TestBackend//p:DisableImplicitNuGetFallbackFolder=true nfig/composer/ve--verbosity ing/packages(dns block)imzvsblobprodcus368.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/D85692722C87C5CC860C8C97E3964764/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)josvsblobprodcus372.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E7B5E0C97290FB53C2DCA420CF493E2A/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)k0ivsblobprodcus356.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/2F791F74279429A4411827997DA8D4D6/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E8B33609F82B4D2DB59C009A9FC7A4C1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force eql-�� deql-scratch/dbs/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackabash ess/TestBackend//p:DisableImplicitNuGetFallbackFolder=true nfig/composer/ve--verbosity ing/packages(dns block)k4kvsblobprodcus344.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E7B5E0C97290FB53C2DCA420CF493E2A/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)l49vsblobprodcus358.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/70593C6D7716240F283A24747D312FA1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)ljcvsblobprodcus317.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E8B33609F82B4D2DB59C009A9FC7A4C1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force eql-�� deql-scratch/dbs/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackabash ess/TestBackend//p:DisableImplicitNuGetFallbackFolder=true nfig/composer/ve--verbosity ing/packages(dns block)m8dvsblobprodcus37.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/E8B33609F82B4D2DB59C009A9FC7A4C1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force eql-�� deql-scratch/dbs/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackabash ess/TestBackend//p:DisableImplicitNuGetFallbackFolder=true nfig/composer/ve--verbosity ing/packages(dns block)ocsp.godaddy.com/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/070F606598054205578256E76ACC5529/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/7C413E517467CDB6A87A0AA3E5D24D5A/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force 4d-a��(dns block)pc2vsblobprodcus360.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/2F791F74279429A4411827997DA8D4D6/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)se1vsblobprodcus349.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/2F791F74279429A4411827997DA8D4D6/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)sqdvsblobprodcus333.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/uno.extensions/testing/TestHarness/TestHarness.UITest/TestHarness.UITest.csproj --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)ukkvsblobprodcus352.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/676B829A743028324DDBB6E76201DE96/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)uy6vsblobprodcus34.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/70593C6D7716240F283A24747D312FA1/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)v53vsblobprodcus320.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/uno.extensions/src/Uno.Extensions.Reactive.Messaging/Uno.Extensions.Reactive.Messaging.csproj --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)x3yvsblobprodcus370.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/8678811784E46132669587676937D2EF/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force l(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/2718D9FA22CF88B44DA542DEDD70FC6A/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)yttvsblobprodcus357.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/23402928C2CB7C876A271090935211E5/missingpackages_workingdir --packages /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/uno.extensions/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.