Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 14, 2026

GitHub Issue (If applicable): closes #

PR Type

  • Documentation content changes

What is the current behavior?

Documentation incorrectly states that WebAuthenticationProvider uses a "web view" control, implying an embedded WebView component. The actual implementation uses WebAuthenticationBroker API (system authentication window on most platforms) and WinUIEx.WebAuthenticator on Windows.

This creates confusion as evidenced by:

  • Page title: "Authenticate Users with a Web View"
  • Navigation breadcrumb showing "Web View"
  • Multiple references to "web view" throughout documentation
  • No mention of actual WebAuthenticationBroker API being used

What is the new behavior?

Documentation accurately describes the authentication mechanism:

Files updated:

  • doc/Learn/Walkthrough/Authentication.Web.howto.md

    • Title: "Authenticate Users with Web Authentication"
    • Heading: "Let users sign in with web authentication"
    • Replaced "web view" references with accurate terminology: "system authentication window (which may use a system browser)"
    • Clarified that WebAuthenticationBroker API displays an authentication window
  • doc/Learn/Authentication/HowTo-WebAuthentication.md

    • Updated provider description to specify WebAuthenticationBroker API usage
    • Clarified LoginStartUri opens via WebAuthenticationBroker, not embedded WebView
  • doc/Learn/Authentication/AuthenticationOverview.md

    • Updated Web provider description to match actual implementation

Terminology improvements:

  • Changed "system browser or authentication window" to "system authentication window (which may use a system browser)" for clarity
  • Consistently uses "authentication window" to better reflect that WebAuthenticationBroker displays a dedicated authentication window rather than opening the user's default browser

Technical accuracy verified against source:

// src/Uno.Extensions.Authentication.UI/Web/WebAuthenticationProvider.cs
#if WINDOWS
    var userResult = await WinUIEx.WebAuthenticator.AuthenticateAsync(...);
#else
    var userResult = await WebAuthenticationBroker.AuthenticateAsync(...);
#endif

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

No WebView UnoFeature is required (correctly documented). Only Authentication feature needed.

Internal Issue (If applicable):

Original prompt

This section details on the original issue you should resolve

<issue_title>[WebView] [Auth] Wrong Docs title suggesting to be able to use Web Auth provider with WebView</issue_title>
<issue_description>

On which page?

https://github.com/unoplatform/uno.extensions/blob/3faa9bc30d6bd0e3cdacf497f8da71a777b0e53f/doc/Learn/Walkthrough/Authentication.Web.howto.md

What's wrong?

Image Image

The Docs page TOC Entry and Caption is clearly stating that we would be able to use WebView (2?) alongside with Web Authantication Provider, which is at this time at least just wrong!
It would be nice if we could! but not this time.

Also as marked in the secrond screenshot, there would eventually miss the WebView UnoFeature entry also.

Any feedback?

@Kunal22shah you seem to touched this doc the last time, may you can correct this information please?

And just if somone of the Team is interesten in an eventually way to do this with WebView2 as we are now WinUI3 based not UWP itself, maybe you want to check out this msal source code 🚀

just maybe you could even implement this for Uno WebAuthenticationBrokerProvider on Desktop? That would be awesome!
@kazo0 FYI </issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-3012.eastus2.azurestaticapps.net

Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

…vider description

Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
@Jen-Uno Jen-Uno marked this pull request as ready for review January 14, 2026 16:37
Copilot AI changed the title [WIP] Fix wrong documentation title for Web Auth in WebView docs: Fix misleading Web Authentication documentation suggesting WebView usage Jan 14, 2026
@Jen-Uno Jen-Uno requested review from Copilot and kazo0 January 14, 2026 16:37
Copilot AI requested a review from Jen-Uno January 14, 2026 16:37
@Jen-Uno Jen-Uno removed their request for review January 14, 2026 16:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects misleading documentation that incorrectly described WebAuthenticationProvider as using an embedded "web view" control. The documentation is updated to accurately reflect that the implementation uses the system's WebAuthenticationBroker API (or WinUIEx.WebAuthenticator on Windows), which displays a system browser or authentication window rather than an embedded WebView component.

Changes:

  • Updated page title from "Authenticate Users with a Web View" to "Authenticate Users with Web Authentication"
  • Replaced all "web view" references with "WebAuthenticationBroker API" or "system browser/authentication window"
  • Clarified authentication flow descriptions to match actual implementation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
doc/Learn/Walkthrough/Authentication.Web.howto.md Updated title, heading, and multiple references throughout to replace "web view" with accurate WebAuthenticationBroker terminology
doc/Learn/Authentication/HowTo-WebAuthentication.md Updated provider description and LoginStartUri documentation to specify WebAuthenticationBroker API usage
doc/Learn/Authentication/AuthenticationOverview.md Updated Web provider description to match actual implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-3012.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-3012.eastus2.azurestaticapps.net

@Jen-Uno
Copy link
Contributor

Jen-Uno commented Jan 14, 2026

@copilot apply changes based on the comments in this thread

Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-3012.eastus2.azurestaticapps.net

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WebView] [Auth] Wrong Docs title suggesting to be able to use Web Auth provider with WebView

3 participants