Skia support, multi-editors, monaco updates #28

clairernovotny · 2025-10-20T23:08:35Z

This pull request introduces several significant improvements and updates across the codebase, focusing on modernizing project configuration, improving nullability and event handling, updating dependencies and build tooling, and enhancing the code editor's initialization logic. The changes aim to make the project more robust, maintainable, and compatible with newer tooling.

Project structure and configuration modernization:

Added Directory.Build.props, Directory.Build.targets, and Directory.Packages.props files to enable central management of build properties and package versions, including enabling implicit usings, nullable reference types, treating warnings as errors, and suppressing specific warnings (NU1507, NETSDK1201, PRI257, CS1998). [1] [2] [3]
Updated the solution file (MonacoEditorComponent.sln) and introduced a solution filter (MonacoEditorComponent.slnf) to improve project organization and streamline loading in Visual Studio. [1] [2] [3]

Dependency and tooling updates:

Upgraded monaco-editor, typedoc, and typescript dependencies to more recent versions in GenerateMonacoTypings/package.json. Also updated the TypedocConverter tool to v2.6 and adjusted the PowerShell script to use new options for type conversion. [1] [2] [3]

Build process enhancements:

Modified the CI pipeline configuration (.vsts-ci.yml) to use the new solution filter file, added binary logging to MSBuild, and ensured artifacts are always published regardless of build success. [1] [2]

Code editor improvements and nullability:

Refactored event declarations in CodeEditor.Events.cs to use nullable event handlers and renamed events for clarity (e.g., EditorLoading, EditorLoaded). Improved null safety throughout the file, updated initialization logic, and enhanced focus management and theme handling to be more robust and compatible with nullable reference types. [1] [2] [3] [4] [5]
Updated the CommandHandler delegate in CodeEditor.Methods.cs to accept nullable parameters, aligning with the project's move to nullable reference types.

These changes collectively modernize the project, improve safety and maintainability, and ensure compatibility with current .NET and JavaScript tooling.

Updated Uno.WinUI package version in Directory.Packages.props to 6.4.0-dev.212. Enhanced MonacoEditorComponent.csproj to support net10.0 framework alongside net9.0, including updates to target frameworks, conditional property groups, and item groups. Modified App.xaml.cs to navigate to MainPage by default. Added BlazorWebAssemblyJiterpreter property in MonacoEditorTestApp.csproj and generalized file inclusion pattern for browserwasm.

Updated the `Uno.WinUI` package to `6.4.0-dev.235` and the `Uno.Sdk` versions in `global.json` to `6.4.0-dev.50` and `6.4.0-dev.256`. Changed the project SDK in `MonacoEditorTestApp.csproj` from `Uno.Sdk.Private` to `Uno.Sdk` and upgraded the target framework to `net10.0-browserwasm`. Commented out unused embedded resources in `MonacoEditorComponent.csproj` and added the `<WasmFingerprintAssets>` property with a value of `false` to optimize asset handling.

Copilot

Pull Request Overview

This pull request updates the Monaco Editor dependency to a newer version and modernizes the project's build configuration. The changes introduce centralized package management, enable nullable reference types, and update build tooling to improve maintainability and type safety across the codebase.

Key changes:

Centralized build configuration with Directory.Build.props/targets and Directory.Packages.props
Monaco Editor and related dependencies upgraded to newer versions
Solution filter added to streamline project loading
Event handling refactored to support nullable reference types

Reviewed Changes

Copilot reviewed 188 out of 306 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Directory.Build.props	Adds central project properties including nullable reference types and warning configurations
Directory.Build.targets	Adds shared build targets for artifact publishing
Directory.Packages.props	Introduces central package version management
MonacoEditorComponent.slnf	Adds solution filter for selective project loading
GenerateMonacoTypings/package.json	Updates monaco-editor, typescript, and typedoc dependencies
.vsts-ci.yml	Updates CI to use solution filter and adds binary logging
CodeEditor.Events.cs	Refactors events to use nullable event handlers and improves initialization logic
monaco-editor/min/vs/*	Updates Monaco Editor library files to newer version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Modernized versioning by replacing `gitversion.yml` with `version.json` using the `Nerdbank.GitVersioning` schema. Added a global package reference for `Nerdbank.GitVersioning` (v3.8.118) in `Directory.Packages.props`. Updated `MonacoEditorComponent.csproj`: - Changed `Title` to "Monaco Editor Component WASM". - Enhanced NuGet metadata with `Authors`, `Copyright`, `PackageLicenseExpression`, and `PackageTags`. - Simplified packaging by removing `NuspecProperties` and `NuspecFile`. - Excluded unnecessary files from the NuGet package using `Pack="false"`. Improved project structure and clarified the scope of the Monaco Editor component.

- Added `<ContinuousIntegrationBuild>` property for CI builds. - Updated copyright year to dynamically use the current year. - Adjusted content packaging rules to include necessary files. - Introduced framework-specific content packaging logic. - Improved handling of primary target framework extraction. - Allowed `.pdb` files in package build output. - Removed deprecated `<GenerateLibraryLayout>` property. - General cleanup of content inclusion and resource declarations.

…n sources. Switch CI to Ubuntu, update build props, and nuget config Updated the CI pipeline to use `ubuntu-latest` instead of `windows-latest` for the `Windows` job. Added the `<UseArtifactsOutput>` property in `Directory.Build.props` to enable artifact output.

Copilot

Pull Request Overview

Copilot reviewed 208 out of 425 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 208 out of 425 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

carldebilly · 2025-11-04T17:07:52Z

.editorconfig

+root = true
+
+[*]
+indent_style = space


Spaces... it hurts me :-) But I understand it's a fork...

carldebilly · 2025-11-04T17:10:57Z

Directory.Packages.props

+    <PackageVersion Include="Uno.Core.Extensions.Logging" Version="4.1.1" />
+    <PackageVersion Include="Uno.Core.Extensions.Logging.Singleton" Version="4.1.1" />
+    <PackageVersion Include="Microsoft.TypeScript.MSBuild" Version="5.9.3" />
+    <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.8.118"/>


Didn't know we can do that. That's nice.

carldebilly · 2025-11-04T17:11:53Z

MonacoEditorComponent.slnx

+  <Configurations>
+    <Platform Name="Any CPU" />
+    <Platform Name="ARM" />
+    <Platform Name="ARM64" />
+    <Platform Name="x64" />
+    <Platform Name="x86" />
+  </Configurations>
+  <Folder Name="/Solution Items/">


Pretty sure Any CPU is enough.

Suggested change

<Configurations>

<Platform Name="Any CPU" />

<Platform Name="ARM" />

<Platform Name="ARM64" />

<Platform Name="x64" />

<Platform Name="x86" />

</Configurations>

<Folder Name="/Solution Items/">

<Folder Name="/Solution Items/">

carldebilly · 2025-11-04T17:12:45Z

changelog.md

Is this file still relevant?

carldebilly · 2025-11-04T17:14:07Z

global.json

+    "Uno.Sdk": "6.4.0-dev.50",
+    "Uno.Sdk.Private": "6.4.0-dev.256"


Usually we don't use both in a same solution or it would cause strange problems with the DevServer.

I suggestion keeping only Uno.Sdk.Private here.

Note: Uno.Sdk 6.4.0-dev.50 uses Uno version 6.4.0-dev.235, not 6.4.0-dev.256

carldebilly · 2025-11-04T17:20:06Z

MonacoEditorComponent/MonacoEditorComponent.csproj

-			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-		</PackageReference>
-
+		<PackageReference Include="Newtonsoft.Json" />


Is there a way to ditch this dependency?

carldebilly · 2025-11-04T17:40:26Z

MonacoEditorComponent/ts-helpermethods/Monaco.Helpers.ParentAccessor.ts

No namespace here ??

carldebilly · 2025-11-04T17:41:14Z

MonacoEditorComponent/ts-helpermethods/asyncCallbackHelpers.ts

+    });
+
+    // Set theme
+    console.debug("Getting parent theme value");


Debugging code...

Updated `.vsts-ci.yml` to adjust artifact publishing paths: - Changed publish path to `package/release` for better structure. - Removed redundant log publishing path. Modified `Directory.Build.targets` to include a `SourceRoot` item: - Dynamically includes `$(ArtifactsPath)` if the variable is set. - Supports improved build and packaging workflows.

Updated the `<SourceRoot>` element in `Directory.Build.targets` to append a trailing slash (`/`) to the `$(ArtifactsPath)`

Copilot

Pull Request Overview

Copilot reviewed 208 out of 425 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

carldebilly

LGTM

Copilot

Pull Request Overview

Copilot reviewed 209 out of 426 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

MonacoEditorComponent/monaco-editor/min/vs/editor/editor.main.nls.de.js:1

This entire file has been deleted which appears to be a German localization file. Ensure that German language support is intentionally being removed and that this won't break existing functionality for German-speaking users.
MonacoEditorComponent/monaco-editor/min/vs/css-CaeNmE3S.js:1
The entire file content structure has changed from a multi-line AMD module definition to a single-line minified format. The version reference changed from 0.34.0 to being removed entirely. Verify that this represents a legitimate Monaco Editor upgrade and that the new format is compatible with the application's module loading system.

define("vs/css-CaeNmE3S",["exports"],(function(e){"use strict";const t={wordPattern:/(#?-?\d*\.\d\w*%?)|((::|[@#.!:])?[\w-?]+%?)|::|[@#.!:]/g,comments:{blockComment:["/*","*/"]},brackets:[["{","}"],["[","]"],["(",")"]],autoClosingPairs:[{open:"{",close:"}",notIn:["string","comment"]},{open:"[",close:"]",notIn:["string","comment"]},{open:"(",close:")",notIn:["string","comment"]},{open:'"',close:'"',notIn:["string","comment"]},{open:"'",close:"'",notIn:["string","comment"]}],surroundingPairs:[{open:"{",close:"}"},{open:"[",close:"]"},{open:"(",close:")"},{open:'"',close:'"'},{open:"'",close:"'"}],folding:{markers:{start:new RegExp("^\\s*\\/\\*\\s*#region\\b\\s*(.*?)\\s*\\*\\/"),end:new RegExp("^\\s*\\/\\*\\s*#endregion\\b.*\\*\\/")}}},n={defaultToken:"",tokenPostfix:".css",ws:`[

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…n timing and syntax highlighting (#29)

CLAassistant · 2025-11-06T18:19:18Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ jeromelaban
✅ MartinZikmund
✅ clairernovotny
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Introduced a `FileExtension` property in the `CodeEditor` class to automatically determine the code language based on file extensions. This is backed by a new `DependencyProperty` and integrates with a JavaScript function `languageIdFromFileName` for language mapping using Monaco Editor. - Added `LanguageIdFromFileName` method in `NativeMethods` for JS interop. - Implemented `languageIdFromFileName` in `asyncCallbackHelpers.ts`. - Updated `globalThis` to include the new function. - Refactored `using` directives for consistency and removed redundancies. - Added XML documentation for the `FileExtension` property. - Improved maintainability and readability across related files.

Copilot

Pull Request Overview

Copilot reviewed 209 out of 426 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Added the `AllowForWeb` attribute to enable JavaScript access to the `DebugLogger` class in UWP apps. Suppressed the CA1822 warning for the `Log` method to avoid marking it as static, ensuring compatibility with the existing design. Reformatted the `#if DEBUG` block for improved readability and consistency.

Replaced `FileExtension` property in `CodeEditor` with a new approach that determines code language based on file extensions. Removed the `LanguageIdFromFileName` method and introduced `LanguageIdFromExtension` for improved efficiency and clarity. - Removed `FileExtension` property and its `DependencyProperty` logic. - Updated `globalThis.languageIdFromFileName` to `languageIdFromExtension` in JavaScript. - Modified `LanguagesHelper` to include `GetCodeLanguageFromExtension` method. - Changed `LanguagesHelper` class to `sealed partial` for extensibility. - Adjusted imports and removed unused namespaces for cleanup. - Updated comments and attributes to reflect the new design. These changes simplify the codebase, reduce redundancy, and align with best practices for language detection.

The `JSImport` attribute for the `LanguageIdFromExtension` method in the `NativeMethods` class was updated to reference the `languageIdFromExtension` function from `globalThis` instead of `languageIdFromFileName`. This change reflects a shift in functionality to determine the language ID based on file extensions rather than file names.

Copilot

Pull Request Overview

Copilot reviewed 211 out of 428 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jeromelaban and others added 25 commits February 21, 2025 17:25

wip

0fdc237

wip

e342be9

wip

66a9715

wip

34f29f1

nullable

e1ee696

more nullable

e87691c

more fixes

91de2e3

chore: Adjust format

573c03f

Update to use latest uno 6 templates

009df7d

update to uno latest

e372c73

chore: Add missing file

9188eac

Update dependency versions

f6c108c

Update to latest Monaco (0.52.0)

e107b04

Auto add and activate tab

a97cb77

NullReferenceException repro

4e45c7b

Add missing styles

71a2325

Add resources for 6.3

a0b2055

Don't refresh layout until editor is fully loaded

34b6abd

use private sdk

ecce003

add simple test page

3763ba3

Update to latest sdks

b1c02f6

Update to Monaco Editor 0.54

f3841a1

Refactor and cleanup project files

c94facc

Copilot AI review requested due to automatic review settings October 27, 2025 17:50

Copilot AI reviewed Oct 27, 2025

View reviewed changes

clairernovotny added 3 commits October 27, 2025 17:29

Properly include all of the monaco files

f66480a

clairernovotny added 2 commits November 4, 2025 11:50

Set name to Build

8cd90a3

Copilot AI review requested due to automatic review settings November 4, 2025 16:52

Copilot AI reviewed Nov 4, 2025

View reviewed changes

clairernovotny added 2 commits November 4, 2025 11:56

Simplify artifact publishing and fix variable casing

2246c37

fix case

4486014

Copilot AI review requested due to automatic review settings November 4, 2025 17:13

Copilot AI reviewed Nov 4, 2025

View reviewed changes

carldebilly reviewed Nov 4, 2025

View reviewed changes

clairernovotny added 2 commits November 4, 2025 13:05

Ensure directory path in SourceRoot Include attribute

fe7ccf3

Updated the `<SourceRoot>` element in `Directory.Build.targets` to append a trailing slash (`/`) to the `$(ArtifactsPath)`

Copilot AI review requested due to automatic review settings November 4, 2025 18:37

Copilot AI reviewed Nov 4, 2025

View reviewed changes

carldebilly reviewed Nov 5, 2025

View reviewed changes

jeromelaban changed the title ~~Dev/cnov/Monaco updates~~ Skia support, multi-editors, monaco updates Nov 5, 2025

jeromelaban approved these changes Nov 5, 2025

View reviewed changes

clairernovotny added 2 commits November 5, 2025 13:26

added copilot setup

354fa84

set sdk ver

7bf9808

Copilot AI review requested due to automatic review settings November 5, 2025 18:32

Copilot AI reviewed Nov 5, 2025

View reviewed changes

Apply initial property values on CodeEditor load to fix initializatio…

a68a6be

…n timing and syntax highlighting (#29)

Copilot AI review requested due to automatic review settings November 6, 2025 18:51

Copilot AI reviewed Nov 6, 2025

View reviewed changes

clairernovotny added 3 commits November 6, 2025 13:54

Copilot AI review requested due to automatic review settings November 6, 2025 19:44

Copilot AI reviewed Nov 6, 2025

View reviewed changes

		"Uno.Sdk": "6.4.0-dev.50",
		"Uno.Sdk.Private": "6.4.0-dev.256"

Skia support, multi-editors, monaco updates #28

Are you sure you want to change the base?

Skia support, multi-editors, monaco updates #28

Uh oh!

Conversation

clairernovotny commented Oct 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carldebilly Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

carldebilly left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

CLAassistant commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

carldebilly Nov 4, 2025 •

edited

Loading

CLAassistant commented Nov 6, 2025 •

edited

Loading