fix: always generate extension #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpinedam
force-pushed
the
dev/ajpm/always.generate.extension
branch
from
a229122 to
afa0e5a
Compare
|
@jeromelaban this is the PR I mentioned earlier today. Windows Target does not see the generated extension. |
ajpinedam
force-pushed
the
dev/ajpm/always.generate.extension
branch
from
2a3a682 to
52496ab
Compare
ajpinedam
force-pushed
the
dev/ajpm/always.generate.extension
branch
from
9d50ceb to
f2ec217
Compare
Xiaoy312
approved these changes
Apr 2, 2025
ajpinedam
force-pushed
the
dev/ajpm/always.generate.extension
branch
from
f2ec217 to
b536dd3
Compare
Co-authored-by: Xiaotian Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #289
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):