-
Notifications
You must be signed in to change notification settings - Fork 29
feat!: switch InputExtensions.ReturnType to InputReturnType #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kunal22shah
wants to merge
1
commit into
main
Choose a base branch
from
dev/ks/switch-InputExtensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazo0
reviewed
May 21, 2025
kazo0
reviewed
May 22, 2025
650f3dd
to
7c1ec70
Compare
Xiaoy312
reviewed
May 23, 2025
14e8f42
to
659b1bb
Compare
kazo0
approved these changes
May 24, 2025
659b1bb
to
5b69834
Compare
kazo0
reviewed
May 27, 2025
Xiaoy312
reviewed
May 27, 2025
src/Uno.Toolkit.UI/Controls/ExtendedSplashScreen/ExtendedSplashScreen.cs
Show resolved
Hide resolved
e1c9c42
to
3c540e3
Compare
kazo0
reviewed
May 27, 2025
kazo0
reviewed
May 27, 2025
BREAKING CHANGE: Uno dependency has been bumped to 6.0 and the InputExtensions.ReturnType has been changed to InputReturnType.
c1bf8f2
to
90726e9
Compare
kazo0
reviewed
Jun 6, 2025
@Kunal22shah I'm not seeing the keyboard type changing between the different input types, at least not on Android. The only one where it changes in the Search type: Screen.Recording.2025-06-13.at.5.20.03.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1387
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):