Skip to content

fix(TextBox): fix MaxLength to work correctly with paste #19665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(TextBox): fix MaxLength to work correctly with paste #19665

wants to merge 2 commits into from
+57 −15

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #19591

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Mar 11, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19665/index.html

ajpinedam
ajpinedam approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@unodevops
Copy link
Contributor

⚠️⚠️ The build 157339 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19665/index.html

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.6

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 11, 2025

backport release/stable/5.6

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@jeromelaban
Copy link
Member

@ramezgerges the ios failure seem to be valid: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=3265723&_a=resultSummary&resultId=100000

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19665/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 160793 has failed on Uno.UI - CI.

@ramezgerges
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19665/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19665/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 162640 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception is thrown when writing more characters than the available in TextBox
5 participants
@ramezgerges @unodevops @jeromelaban @MartinZikmund @ajpinedam