Skip to content

Conversation

@yaobiao131
Copy link
Contributor

@yaobiao131 yaobiao131 commented Apr 4, 2025

…inui, and prioritize classes with Extension extensions

GitHub Issue (If applicable): closes #19801

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When I created two classes named ResourcesExtension and Resources in same namespace, ResourcesExtension implemented MarkupExtension and Resource is a static class. It can be parsed to ResourcesExtension normally in winui, but in uno, it will first search for the static class Resources.

What is the new behavior?

The search behavior is consistent with winui, and classes with Extension extensions are searched first.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

…inui, and prioritize classes with Extension extensions
@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Apr 4, 2025
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19838/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19838/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 159813 has failed on Uno.UI - CI.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2025

CLA assistant check
All committers have signed the CLA.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 162958 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 162959 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19838/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19838/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19838/index.html

@yaobiao131
Copy link
Contributor Author

anything update?

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19838/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19838/docs/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 165177 has failed on Uno.UI - CI.

@Xiaoy312 Xiaoy312 self-requested a review May 11, 2025 19:35
@jeromelaban jeromelaban merged commit 67ad68a into unoplatform:master May 13, 2025
87 checks passed
@welcome
Copy link

welcome bot commented May 13, 2025

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

DevTKSS pushed a commit to DevTKSS/uno that referenced this pull request May 31, 2025
fix: Ensure that MarkupExtension search behavior is consistent with winui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/code-generation Categorizes an issue or PR as relevant to code generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MarkupExtension search behavior is inconsistent with winui

5 participants