Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sidebar): add minScreen prop #848

Closed
wants to merge 3 commits into from
Closed

Conversation

JollyBanny
Copy link
Contributor

@JollyBanny JollyBanny commented Oct 30, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently Sidebar component doesn't allow to set the screen size for display the sidebar as sidebar or sidepage. By default screen size all <= md is sidepage and md > all is sidebar.
Property minScreen will allow to set min screen size when sidebar switches from sidepage to sidebar.
p.s. sidepage (mobile), sidebar(desktop)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@zernonia
Copy link
Member

zernonia commented Nov 2, 2024

Thanks for the PR! However this prop is not available on Sidebar implementation, thus will be closing this for now.

You are free to make those adjustment in your own local sidebar component 😁

@zernonia zernonia closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants