Disable sherlock assistant by default #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
|
🎉 All your tests were successful! |
There was a problem hiding this comment.
Pull Request Overview
This PR disables the Sherlock Assistant by default to address website compatibility issues by renaming the related preferences property and updating the associated logic.
- Renames the "Scanning" property to "Sherlock" across multiple modules.
- Updates relevant UI logic and context menu handling to reference "Sherlock".
- Bumps the package version and updates the changelog.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types/wallet/preferences.ts | Renamed the preferences key from "Scanning" to "Sherlock". |
| src/pages/Wallet/Preferences.tsx | Updated preference initialization and toggling logic for Sherlock. |
| src/pages/Legacy/Extension.tsx | Adjusted the legacy extension's handling of preference defaults. |
| src/lib/wallet/preferences.ts | Modified default and normalization of sheriff preferences. |
| src/lib/sherlock/contextMenu.ts | Updated context menu logic to use "Sherlock" instead of "Scanning". |
| package.json | Bumped version to 3.1.63. |
| CHANGELOG.md | Logged the change to disable Sherlock by default. |
Co-authored-by: Copilot <[email protected]>
|
🎉 All your tests were successful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have experienced website compatibility issues when using the Sherlock Assistant feature. To address this, we have disabled the Sherlock Assistant by default in this release. It is now an opt-in feature.