Change warning to pragma message for MSVC comp#709
Open
fran6co wants to merge 1 commit intounum-cloud:mainfrom
Open
Change warning to pragma message for MSVC comp#709fran6co wants to merge 1 commit intounum-cloud:mainfrom
fran6co wants to merge 1 commit intounum-cloud:mainfrom
Conversation
Contributor
|
Thank you, @fran6co! I'll need to check that it doesn't break the builds for other compiler, but seems like we may be able to merge that. Do you have any details about the original issue you are trying to solve with this? |
Author
|
Hi, I was hitting this when building with vcpkg. There is nothing preventing the code reach that place using a compiler that is not MSVC (that I think it was the intended target). I think that normally doesn't happen and probably this fix is not really needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.