Rust & Python Improvements #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an unsafe block Add another vector to Index after changing metric in test
Store the closure's raw pointer instead of the Box Also fixed some typos
Fix: Properly deallocate the closure when dropping the Index
Co-authored-by: Ash Vardanian <[email protected]> Co-authored-by: Laurens Priem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @frank-lsf, viewing Python's native
buffers works as expected! Thanks to @couguiv, passing closures from Rust to C++ is also fixed! Thanks to @laurenspriem, Rust users can now also run each search queries! This PR also adds concurrent tests using Fork Union, instantiating many threads, indexing & searching concurrently 🚀