change scope classmethods to staticmethods #10
Conversation
examples/scope_example.py
Outdated
|
|
||
| # compare both waveforms | ||
| pss.Scope.compare_channels(meas_il_ib, gecko_il_ib, meas_il_ob, gecko_il_ob, shift=[-67.53e-6, 0, -67.53e-6, 0], timebase='us') | ||
| # pss.HandleScope.compare_channels(meas_il_ib, gecko_il_ib, meas_il_ob, gecko_il_ob, shift=[-67.53e-6, 0, -67.53e-6, 0], timebase='us') |
There was a problem hiding this comment.
What is the reason for comment out? It shall plot the function, or is it obsolete because also other functions plots the function?
pysignalscope/scope.py
Outdated
| :return: None | ||
| :rtype: None | ||
| :return: Scope object | ||
| :rtype: Scope | ||
| """ | ||
| if isinstance(channel_label, str) or channel_label is None: |
There was a problem hiding this comment.
Before assigning any value to the dataset attribute a deep copy is necessary. Otherwise you overwrite the origin data of the data set.
So each function needs a deep copy, like
cur_channel=copy(channel)
Then the attributes of cur_channel can be updated and cur_channel can be returned
pysignalscope/scope.py
Outdated
| self.channel_data = np.abs(self.channel_data) | ||
| if self.channel_label is not None: | ||
| self.channel_label = '|' + self.channel_label + '|' | ||
| channel.channel_data = np.abs(channel.channel_data) |
There was a problem hiding this comment.
Before calculation of absolute values a copy of the data are necessary. Otherwise you overwrite the origin channel data.
pysignalscope/scope.py
Outdated
| self.channel_data = self.channel_data ** 2 | ||
| if self.channel_label is not None: | ||
| self.channel_label = self.channel_label + '²' | ||
| channel.channel_data = channel.channel_data ** 2 |
There was a problem hiding this comment.
Before calculation of square values a copy of the data are necessary. Otherwise you overwrite the origin channel data.
|
Requested changes are fixed. |
No description provided.