Skip to content

add save/load functionality #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

add save/load functionality #16

merged 2 commits into from
Dec 2, 2024

Conversation

gituser789
Copy link
Contributor

No description provided.

@gituser789 gituser789 self-assigned this Nov 28, 2024
@gituser789 gituser789 added the enhancement New feature or request label Nov 28, 2024
@gituser789 gituser789 added this to the 0.2.0 milestone Nov 28, 2024
@gituser789 gituser789 linked an issue Nov 28, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@SevenOfNinePE SevenOfNinePE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far ok, but currently it is only storage and load of scope data.
Missing are the update (in case of save) and check (in case of load) of the meta data.
These features are mentioned under 'Thought' but part of the change item.
Either move to another change item or keep it in this item.
'Keep it' means these has to implement before pull request can be approved.

@gituser789
Copy link
Contributor Author

Updated. This is the basic save/load.
Now, there is another draft improve save/load in future, once these keys are implemented.

@gituser789 gituser789 merged commit 2f72e05 into main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to save and load a Scope object
2 participants