-
Notifications
You must be signed in to change notification settings - Fork 0
Implement low-pass filter #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both functions:
How is the behaviour, if values are added, which leads to a negative answer of the called toolbox function m'FinDiff'. E.g. what happend in case of order=10000000. Or the angular_frequency_rad=1.2? I know, the last call is prevented, but e.g. order of 1000000 may leads to a negative answer of the calling function 'signal.butter' you prevent this). How is this situation handled. If the python raise an error and stops the program, this is ok, but if the program continues, it could be a problem.
examples/scope_example.py
Outdated
|
||
# Shift first two channels and plot the shift of these channels | ||
shiftlist = pss.HandleScope.plot_shiftchannels([voltage_prim, voltage_sec]) | ||
|
||
print(f"{shiftlist=}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this it a test comment and needs to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
depending on the available datapoints, the external toolbox will stop working by ruinning into an error. Then, more datapoints are needed to do the derivation for the signal. We can also limit the max. derivation to practical values, e.g. 2 or 3 |
configurable, ready-to-use low pass filter
additionally, add derivative
Small fixes in the whole code