Skip to content

Implement low-pass filter #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Implement low-pass filter #18

merged 7 commits into from
Dec 4, 2024

Conversation

gituser789
Copy link
Contributor

@gituser789 gituser789 commented Dec 3, 2024

configurable, ready-to-use low pass filter

  • generate a copy of the incoming scope object
  • implement low-pass-filter, configurable
  • return modified scope object
  • implement unit test for this method

additionally, add derivative

  • generate copy of the incoming scope object
  • implement derivative, configurable
  • return modified scope object
  • implement unit tests for this method

Small fixes in the whole code

  • lot of typos
  • small datatype fixes in return/docs

@gituser789 gituser789 added the enhancement New feature or request label Dec 3, 2024
@gituser789 gituser789 added this to the 0.2.0 milestone Dec 3, 2024
@gituser789 gituser789 self-assigned this Dec 3, 2024
@gituser789 gituser789 linked an issue Dec 3, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@SevenOfNinePE SevenOfNinePE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both functions:
How is the behaviour, if values are added, which leads to a negative answer of the called toolbox function m'FinDiff'. E.g. what happend in case of order=10000000. Or the angular_frequency_rad=1.2? I know, the last call is prevented, but e.g. order of 1000000 may leads to a negative answer of the calling function 'signal.butter' you prevent this). How is this situation handled. If the python raise an error and stops the program, this is ok, but if the program continues, it could be a problem.


# Shift first two channels and plot the shift of these channels
shiftlist = pss.HandleScope.plot_shiftchannels([voltage_prim, voltage_sec])

print(f"{shiftlist=}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this it a test comment and needs to be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@gituser789
Copy link
Contributor Author

depending on the available datapoints, the external toolbox will stop working by ruinning into an error. Then, more datapoints are needed to do the derivation for the signal.

We can also limit the max. derivation to practical values, e.g. 2 or 3

@gituser789 gituser789 merged commit 3601b1f into main Dec 4, 2024
2 checks passed
@gituser789 gituser789 deleted the unit_tests branch December 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement low pass filter method
2 participants