Skip to content

add impedance feature #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2024
Merged

add impedance feature #8

merged 4 commits into from
Nov 7, 2024

Conversation

gituser789
Copy link
Contributor

@gituser789 gituser789 commented Nov 5, 2024 •
edited
Loading

New feature to generate, modify and plot impedance curves from an impedance analyzer.

Implemented

  • Feature in general implemented
  • Architecture by using @dataclass and a class to modify and handle the data

Not Implemented yet

  • Input check for user data (-> New issue)

@gituser789 gituser789 self-assigned this Nov 5, 2024
@gituser789 gituser789 added the enhancement New feature or request label Nov 5, 2024
@gituser789 gituser789 added this to the 0.2.0 milestone Nov 5, 2024
@gituser789 gituser789 linked an issue Nov 5, 2024 that may be closed by this pull request
Add Impedance plots to the toolbox #9
Closed
2 tasks
SevenOfNinePE
SevenOfNinePE requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@SevenOfNinePE SevenOfNinePE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach is fine (separation of program and data). Issue is the missing copy of data so that the origin data are not modified.

@SevenOfNinePE SevenOfNinePE merged commit 84c0683 into main Nov 7, 2024
2 checks passed
@gituser789 gituser789 deleted the check_type branch December 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenOfNinePE SevenOfNinePE SevenOfNinePE approved these changes

Assignees

@gituser789 gituser789

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Add Impedance plots to the toolbox
2 participants
@gituser789 @SevenOfNinePE