Skip to content

Conversation

@NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

@NathanBaulch NathanBaulch changed the title Fix typos fix: typos Oct 7, 2024
@NathanBaulch
Copy link
Contributor Author

NathanBaulch commented Oct 7, 2024

This also includes a few fixes to get through the CI checks:

  • broken unit tests introduced in test: add unit test for parser #978 due to Parser.SkipBytes -> Parser.SkipPrefix changes
  • migrate reflect.PtrTo -> reflect.PointerTo (staticcheck)
  • normalize to Unix line endings in parser_test.go

The current CI failure is due to a MSSQL container panic - not much I can do about that.

@vmihailenco
Copy link
Member

Thanks

@vmihailenco vmihailenco merged commit 760de7d into uptrace:master Oct 9, 2024
3 of 4 checks passed
@NathanBaulch NathanBaulch deleted the typos branch October 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants