Skip to content

feat(migrate): implement migration sort customization #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(migrate): implement migration sort customization #1186

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60f07c3
fix(migrations): sort migrations as ints not strings
jeffreydwalter Apr 17, 2025
5a70b4e
Merge branch 'uptrace:master' into jeffreydwalter-fix-migration-sort
jeffreydwalter May 5, 2025
3de66a6
feat(migrate): implement migration sort customization
jeffreydwalter May 5, 2025
43ec518
Update migrate/migrator.go
jeffreydwalter May 6, 2025
5b9b52c
Update migrator.go
jeffreydwalter May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions migrate/migration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"io"
"io/fs"
"sort"
"strconv"
"strings"
"time"

Expand Down Expand Up @@ -291,12 +292,22 @@ func WithNopMigration() MigrationOption {

func sortAsc(ms MigrationSlice) {
sort.Slice(ms, func(i, j int) bool {
ni, ei := strconv.ParseInt(ms[i].Name, 10, 64)
nj, ej := strconv.ParseInt(ms[j].Name, 10, 64)
if ei == nil && ej == nil && ni != nj {
return ni < nj
}
return ms[i].Name < ms[j].Name
})
}

func sortDesc(ms MigrationSlice) {
sort.Slice(ms, func(i, j int) bool {
ni, ei := strconv.ParseInt(ms[i].Name, 10, 64)
nj, ej := strconv.ParseInt(ms[j].Name, 10, 64)
if ei == nil && ej == nil && ni != nj {
return ni > nj
}
return ms[i].Name > ms[j].Name
})
}
Loading