feat: add SortDir type to safely build order queries #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
force-pushed
the
feat/sort-dir
branch
from
aa7d500 to
972780b
Compare
bevzzz
reviewed
Oct 20, 2025
|
|
||
| //------------------------------------------------------------------------------ | ||
|
|
||
| type SortDir string |
There was a problem hiding this comment.
Would it make sense to call this type Order? I know "sorting direction" is a valid expression, but I find that bun.OrderDesc reads better and is perhaps a tad more intuitive:
.OrderBy("year", bun.OrderDesc)There was a problem hiding this comment.
At the first glance Dir also made me think of the word "directory" rather than "direction", similarly to fs.Dir from the std
There was a problem hiding this comment.
That's what LLM also suggested, but I wanted to avoid confusion with Order("foo ASC") and OrderBy("foo", SortDirAsc). So:
- order is
col + " " + direction - SortDir is just direction
Maybe I am over-complicating it... Need to check what other libs are using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.