Skip to content

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Oct 3, 2025

Any background context you want to provide?

The Action for publishing the docs had an error. This PR is fixing it

What does this PR accomplish?

  • Temporarily remove a requirement from the sys-param schema to make the validation happy
  • Remove an unnecessary config option in the docs workflow file
  • Bump a docs dependency
  • Use the newest format for the pypi_release.yml file

How should this be manually tested?

What are the relevant tickets?

Screenshots (if appropriate)

@vtnate vtnate self-assigned this Oct 3, 2025
@vtnate vtnate added the documentation Improvements or additions to documentation label Oct 3, 2025
@vtnate vtnate requested a review from Copilot October 3, 2025 19:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with the documentation site publishing workflow and updates related configurations. The main purpose is to resolve validation errors that were preventing the docs Action from running successfully.

Key changes include:

  • Temporarily removing the "weather" requirement from the system parameter schema to fix validation issues
  • Updating documentation dependencies and workflow configurations
  • Modernizing the PyPI release workflow format

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
geojson_modelica_translator/system_parameters/system_parameter_properties.json Removes "weather" requirement and adds new "width_of_ghe" property to fix schema validation
docs/docs_requirements.txt Updates mkdocstrings-python dependency version range
.github/workflows/pypi_release.yml Modernizes workflow format with updated job names, Python version, and formatting
.github/workflows/documentation_site.yml Removes unnecessary CONFIG_FILE environment variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant