Skip to content

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Oct 8, 2025

The URBANopt SDK uses both this repo and NREL-disco. DISCO has a dependency on dsspy that has un-versioned dependencies 🙄. Because of that lack of versioning, DSSpy picks up the newest Shapely, >2.0. That breaks DISCO.

To resolve that, in the UO-SDK we will require Shapely v1.8.5.

That breaks UO-DES, this repo, because of incompatible Shapely versions.

To resolve that, I'm downgrading Geopandas to keep Shapely <2.0.

I'm sorry. 😰

@vtnate vtnate self-assigned this Oct 8, 2025
@vtnate vtnate added the dependencies Pull requests that update a dependency file label Oct 8, 2025
@vtnate vtnate requested a review from Copilot October 8, 2025 19:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the geopandas dependency to address version compatibility issues between UO-DES and NREL-disco within the URBANopt SDK ecosystem. The conflict arises from disco's un-versioned dependencies that pull in newer Shapely versions (>2.0), which break disco functionality.

  • Downgraded geopandas from "^1.0.1" to "<1.0" to maintain Shapely <2.0 compatibility
  • Added explanatory comments documenting the reasoning for the version constraint

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vtnate vtnate requested review from kflemin and nllong October 8, 2025 19:56
@kflemin kflemin self-requested a review October 8, 2025 20:15
@vtnate vtnate merged commit 51091c6 into develop Oct 8, 2025
3 checks passed
@vtnate vtnate deleted the dep-hell branch October 8, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants