Skip to content

Conversation

tanushree04
Copy link
Contributor

@tanushree04 tanushree04 commented Apr 8, 2025

Resolves #[issue number here]

Pull Request Description

[description here]

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@coveralls
Copy link

coveralls commented Apr 21, 2025

Pull Request Test Coverage Report for Build 17567049796

Details

  • 184 of 204 (90.2%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 77.793%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/urbanopt/reopt/reopt_ghp_adapter_ghp.rb 85 105 80.95%
Totals Coverage Status
Change from base Build 17510555273: 1.8%
Covered Lines: 1156
Relevant Lines: 1486

💛 - Coveralls

}
},
"ElectricLoad": {
"load_kw": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change load_kw to loads_kw?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

Copy link

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanushree04 can you provide a bit of a code walk through here? It would be helpful if you could add a few comments at the critical points, just to help us get oriented with the changes you're intending. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants