Fix a few settings to assure accurate GHP LCCA #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanushree04
reviewed
Sep 8, 2025
| "required": true, | ||
| "description": "8760 timeseries of building total electric consumption. It is the total of secondary pump electric power, heat pump electric power and ETS pump power determined from the modelica model. This is used in the LCCA calculation in the GHP iteration.", | ||
| "note": "in the GHX iteration, set this value to a number close to 0 but not exactly 0" | ||
| "description": "8760 timeseries of building total electric consumption. Set to 0 for all GHP and GHX iterations" |
There was a problem hiding this comment.
This will not be 0 for the GHP iteration since it will be total of secondary pump, heat pump and ETS pump power @atpham88 , am I missing something?
tanushree04
reviewed
Sep 8, 2025
| "required": true, | ||
| "description": "8760 timeseries of ghx's total electric consumption. It is the district pump power (in kW), calculated from the modelica model. This is used in the LCCA calculation in the GHX iteration.", | ||
| "note": "in the GHP iteration, set this value to 0" | ||
| "description": "8760 timeseries of ghx's total electric consumption. Set to 0 for all GHP and GHX iterations" |
There was a problem hiding this comment.
This will not be 0 for the GHX iteration since it will be district pump power @atpham88
Please let me know if anything has changed in the REopt API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #[issue number here]
Pull Request Description
[description here]
Checklist (Delete lines that don't apply)