-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USAGOV-2038-tome-cache-page #2040
Conversation
… tome command runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wound up making a branch and deploying that to dev, and I learned that you need to also define cache.backend.null; it's currently only defined for local dev.
So I made those changes in my branch: USAGOV-2038-tome-cache-page-circleci-except
You could merge those, or look at them and do something better.
We won't want to merge the changes I made to .circleci/config.yml into dev, though. But, for future reference, that's how you deploy a random feature branch to dev if you need to do that. All we ask is that your branch be fully up to date with the "dev" branch if you do that.
I've added your branches changes to this branch, though I changed the |
…ds, since its supposed to hold data useful for one request.
…GOV-2038-tome-cache-page' into USAGOV-2038-tome-cache-page
I've updated this branch to use the null backend for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, this looks dandy!
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2038
Description
Disables the page and menu caches when a tome command runs.
Type of Changes
Testing Instructions
Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.