Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2038-tome-cache-page #2040

Merged
merged 8 commits into from
Nov 13, 2024
Merged

USAGOV-2038-tome-cache-page #2040

merged 8 commits into from
Nov 13, 2024

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Oct 25, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2038

Description

Disables the page and menu caches when a tome command runs.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Tome output should be unaffected. Compare exports between this and a run from dev.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@omerida omerida requested a review from akf October 25, 2024 20:38
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wound up making a branch and deploying that to dev, and I learned that you need to also define cache.backend.null; it's currently only defined for local dev.

So I made those changes in my branch: USAGOV-2038-tome-cache-page-circleci-except

You could merge those, or look at them and do something better.

We won't want to merge the changes I made to .circleci/config.yml into dev, though. But, for future reference, that's how you deploy a random feature branch to dev if you need to do that. All we ask is that your branch be fully up to date with the "dev" branch if you do that.

@omerida
Copy link
Contributor Author

omerida commented Nov 4, 2024

I've added your branches changes to this branch, though I changed the container_yamls path to load the new nonlocal services definitions.

@omerida omerida requested a review from akf November 5, 2024 15:14
@omerida
Copy link
Contributor Author

omerida commented Nov 12, 2024

I've updated this branch to use the null backend for the data bin, which is for "data that can vary by path or similar context" according to the docs. That brought export time from about 4mins to almost 3mins locally

Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this looks dandy!

@akf akf merged commit 6070686 into dev Nov 13, 2024
5 of 6 checks passed
@akf akf deleted the USAGOV-2038-tome-cache-page branch November 13, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants