-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USAGOV-2085: PXBF release v0.8.0.beta.1 #2052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierMetichecchia
previously approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
…-release-v0.8.0.beta.1
scottqueen-bixal
changed the title
WIP| PXBF release v0.8.0.beta.1
PXBF release v0.8.0.beta.1
Nov 13, 2024
gchi25
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Worked as expected.
akf
changed the title
PXBF release v0.8.0.beta.1
USAGOV-2085: PXBF release v0.8.0.beta.1
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github Issues
https://github.com/GSA/px-benefit-finder/releases/tag/v0.8.0.beta.1
https://github.com/GSA/px-benefit-finder/milestone/14?closed=1
Related Github Issue
Application Improvements
NEW FEATURE | Return to first step of form, without clearing the form GSA/px-benefit-finder#1473
NEW FEATURE | client side routing in embedded applications GSA/px-benefit-finder#1831
TEST | NGINX redirects for client side routing fallback GSA/px-benefit-finder#1838
Form-page-2 page change event firing twice GSA/px-benefit-finder#1786
Remove crazyegg script value updates from application GSA/px-benefit-finder#1811
Custom Module Improvements
Enable worflow for Benefit Finder nodes that can be in draft GSA/px-benefit-finder#1710
No JSON file generation for moderation state Needs Review GSA/px-benefit-finder#1846
prevent agency archived if still used GSA/px-benefit-finder#1847
Do not use archived content in building JSON data GSA/px-benefit-finder#1858
display raw html GSA/px-benefit-finder#1817
Do not archive criteria if still used GSA/px-benefit-finder#1866
do not archive life event form if still used GSA/px-benefit-finder#1902
Do not archive criteria if still used GSA/px-benefit-finder#1866
Get AJAX HTTP error in JSON file generation when creating new life event GSA/px-benefit-finder#1770
DataLayer Improvements
Remove
data-analytic*
attributes from DOMDesign Improvements
Centering select an option modal text & buttons GSA/px-benefit-finder#1891
Description
Test in progress.
Type of Changes
Testing Instructions
Detailed Testing steps
NEW FEATURE | Return to first step of form, without clearing the form GSA/px-benefit-finder#1473
NEW FEATURE | client side routing in embedded applications GSA/px-benefit-finder#1831
usagov-2021/.docker/src-cms/etc/nginx/partials/internal_redirects.conf
include partials/internal_redirects.conf;
inusagov-2021/.docker/src-cms/etc/nginx/partials/cms.conf.tmpl
/benefit-finder/death
onlocalhost
NEW FEATURE | client side routing in embedded applications GSA/px-benefit-finder#1831
es
NEW FEATURE | Return to first step of form, without clearing the form GSA/px-benefit-finder#1473
TEST | NGINX redirects for client side routing fallback GSA/px-benefit-finder#1838
/death/about-you
Form-page-2 page change event firing twice GSA/px-benefit-finder#1786
/disability
bf_page_change
event for modal and form page 2 only fired onceCustom Module Improvements
Get AJAX HTTP error in JSON file generation when creating new life event GSA/px-benefit-finder#1770
To test in local development site or in dev site.
add/bears_life_event
to create a new life eventadmin/content?combine=&type=bears_criteria&status=All&langcode=All
Do not archive criteria if still used GSA/px-benefit-finder#1866
admin/content?combine=&type=bears_criteria&status=All&langcode=All
Archived
Save
do not archive life event form if still used GSA/px-benefit-finder#1902
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Archived
Save
Enable worflow for Benefit Finder nodes that can be in draft GSA/px-benefit-finder#1710
node/add
Agency
No JSON file generation for moderation state Needs Review GSA/px-benefit-finder#1846
admin/content?combine=&type=bears_agency&status=All&langcode=All
Draft
Needs Review
prevent agency archived if still used GSA/px-benefit-finder#1847
admin/content?combine=&type=bears_agency&status=All&langcode=All
Archived (unpublished)
Save
buttonDo not use archived content in building JSON data GSA/px-benefit-finder#1858
To test in local development site or in dev site.
admin/content?combine=COVID&type=bears_benefit&status=All&langcode=All
Save
display raw html GSA/px-benefit-finder#1817
To test in local development site or in dev site.
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
<a href="http://usagov.gov">USAGov</a>
in summary fieldbenefit-finder/api/life-event/retirement
DataLayer Improvements
Remove
data-analytic*
attributes from DOMhave been removed or replaced by
Design Improvements
Centering select an option modal text & buttons GSA/px-benefit-finder#1891
expected:
Screen.Recording.2024-11-05.at.9.53.29.AM.mov
Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.