Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usagov 2053 ceo error inline message #2061

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

developer43
Copy link
Contributor

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2053

Description

Added text "Error: " to inline error text in the CEO form

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

Goto http://localhost/elected-officials for English and http://localhost/es/funcionarios-electos

  • Submit the form without filling it out so you get the error text
  • Verify the inline error text has "Error: " before each inline error text
Screenshot 2024-11-06 at 10 45 37 AM Screenshot 2024-11-06 at 10 45 49 AM

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@omerida omerida self-requested a review November 8, 2024 21:04
@omerida omerida merged commit 46f0d68 into dev Nov 8, 2024
5 of 6 checks passed
@omerida omerida deleted the usagov-2053-ceo-error-inline-message branch November 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants