Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usagov 2044 drupal 10.3 view suggestions #2067

Open
wants to merge 1 commit into
base: USAGOV-2010-drupal-10.3-upgrade
Choose a base branch
from

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Nov 8, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2044

Description

Applies a modified version of the patch from https://www.drupal.org/project/drupal/issues/2118743 so that view-related template suggestions are displayed if twig debugging is on.

I changed that patch becuase it removed the space between the list icon and the name of the template, causing lines to show up as changed when I diffed the outputs pre- and post-patch.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Enable twig debugging, show template suggestions.
  • Navigate to one or more pages with a view, confirm the HTML comments list view- related template suggestions.

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@akf
Copy link
Member

akf commented Nov 12, 2024

Hi @omerida, could you change this to a PR against the USAGOV-2010-drupal-10.3-upgrade branch and tag @jacobaaronyeager?

@omerida omerida changed the base branch from dev to USAGOV-2010-drupal-10.3-upgrade November 12, 2024 18:50
@omerida omerida marked this pull request as ready for review November 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants