Skip to content

Migrate workflow schedulers to use db-skip-locked like the job handlers in the job conf #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjaysrikakulam
Copy link
Member

See Matrix admin chat for details.

db-preassign is a legacy configuration, and in our job configuration, we use db-skip-locked for the job handlers, so we will switch the workflow schedulers to use the same.

Before merging and deploying this, we should ensure the following and report it,

if the job handlers do not attach to the workflow scheduler pool but do schedule workflows, then that is definitely a bug we want to know about and fix

I am not sure how to test this or if I fully understand it, so I have asked in the chat for guidance on testing.

@sanjaysrikakulam
Copy link
Member Author

if the job handlers do not attach to the workflow scheduler pool but do schedule workflows, then that is definitely a bug we want to know about and fix

Perhaps this means we should verify if the job handlers are scheduling workflows?

@bgruening
Copy link
Member

I think this is what he means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants