-
Notifications
You must be signed in to change notification settings - Fork 31
composer.json file makes installation easier #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: version-1
Are you sure you want to change the base?
Conversation
|
@userjack6880 thanks for approving, do you expect anything from me at this point? |
|
Could you rebase against master, @joostdekeijzer ? |
|
Hi @cweiske, I can't find any master branch on github. I can only see "version-1", "version-1-breakfix" and "version-2-dev"... |
|
Then rebase against whatever version you used as base for your development :) |
|
I see. My original PR was against "version-1" but I see @userjack6880 changed the "base" branch to "version-2-dev". I think the extra commits originate from that. I've changed the "base" branch back to "version-1" again. I can create a new PR for "version-2-dev". Is 2 commits OK for you or should I "squash" it? |
|
Multiple commits make sense when they target different areas or features. If one commit is just a fixup for a previous one, then both should be squashed into one. |
|
I'll squash, hold on (while I Google ;) |
and then in the editor say "f" to the second. |
…` or `composer update`)
471ec7f to
b8a737d
Compare
|
thnx! |
Description
Added composer.json file to make installation of PHP dependencies easier.
Just run
composer installorcomposer update.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested on my local macOS machine with PHPv80
Checklist: