-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary CMake configure support on Windows (#228) #666
Open
leha-bot
wants to merge
8
commits into
userver-framework:develop
Choose a base branch
from
leha-bot:feat/cmake-configure-on-windows
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Preliminary CMake configure support on Windows (#228) #666
leha-bot
wants to merge
8
commits into
userver-framework:develop
from
leha-bot:feat/cmake-configure-on-windows
Commits on Aug 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c5ea832 - Browse repository at this point
Copy the full SHA c5ea832View commit details -
feat cmake: Better search for libev's headers
They are also may be packaged inside "{includedir}/libev/".
Configuration menu - View commit details
-
Copy full SHA for 9093f34 - Browse repository at this point
Copy the full SHA 9093f34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 283a769 - Browse repository at this point
Copy the full SHA 283a769View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef3a75 - Browse repository at this point
Copy the full SHA 6ef3a75View commit details -
feat cmake: Avoid uboost::context on WIN32-like platforms
It's not supported, so use the usual Boost.
Configuration menu - View commit details
-
Copy full SHA for 59308f2 - Browse repository at this point
Copy the full SHA 59308f2View commit details -
feat cmake: Avoid include'ing libc fixes on WIN32-like platforms.
It's no use for the WIN32.
Configuration menu - View commit details
-
Copy full SHA for 9ac1e74 - Browse repository at this point
Copy the full SHA 9ac1e74View commit details -
feat cmake: Use /W4 and /sdl for MSVC as an analogue flags.
Instead of GCC/Clang-like -Wall -Wextra -pedantic. MSVC's /WAll produces a lot of noise, so even MS STL authors had not used it. The /sdl flag adds some static analysis checks. See https://learn.microsoft.com/en-us/cpp/build/reference/sdl-enable-additional-security-checks?view=msvc-170 for details.
Configuration menu - View commit details
-
Copy full SHA for 146b759 - Browse repository at this point
Copy the full SHA 146b759View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b857ed - Browse repository at this point
Copy the full SHA 3b857edView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.