Fix only searching for static libs in zlib, protobuf, etc#877
Closed
Timchenkovich wants to merge 1 commit intouserver-framework:developfrom
Closed
Fix only searching for static libs in zlib, protobuf, etc#877Timchenkovich wants to merge 1 commit intouserver-framework:developfrom
Timchenkovich wants to merge 1 commit intouserver-framework:developfrom
Conversation
fdr400
suggested changes
Mar 11, 2025
| include_guard(DIRECTORY) | ||
|
|
||
| if(USERVER_USE_STATIC_LIBS) | ||
| set(OPENSSL_USE_STATIC_LIBS ON) |
Collaborator
There was a problem hiding this comment.
It is bad solution, IMHO, because it contradicts the USE_STATIC_LIBS idea, we won't accept that.
But, to make this more flexible, you can do something like this:
if(NOT DEFINED OPENSSL_USE_STATIC_LIBS)
set(OPENSSL_USE_STATIC_LIBS ON)
endif()
if(NOT DEFINED Protobuf_USE_STATIC_LIBS)
set(Protobuf_USE_STATIC_LIBS ON)
endif()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #876