-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature improve documentation #329
Conversation
5103e5b
to
f80b2b7
Compare
2ea69e7
to
6686563
Compare
faf4177
to
3ef7073
Compare
05e357e
to
52b289a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working on it ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
- Updated data types to ensure consistency between specification and implementation. - Identify locations of data type schemas in data type specifications. - Discuss use of regular expression dialects used in XML and JSON schema. #235
…the data type implementations restrict leading and trailing whitespace.
Fixed inconsistencies in the tutorial. More terminology alignment.
…stcss work. Added NodeJS setup to website build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I didn't see much and some require judgement but perhaps not action.
Nice job!
Applied some review suggestions. Co-authored-by: Wendell Piez <[email protected]>
…was left in error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found minor types or recommendations on possible stylistic improvement, but those are not important and for the most part subjective. Excellent work, I look forward to finish constraint docs, others areas, and applying what I have learned overall from these docs and put them to good use.
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Committer Notes
This PR represents Metaschema specification improvements made during a full review and edit of the current Metaschema specification.
This PR will address the following issues:
@scope
beinglocal
orglobal
impacts processing of modules from//import
s.Formalize documentation ofjson-key
json-key-value
#316Also addressed:
base64
data type causing values in the rangeg-z
and+/=
to not be valid.All Submissions:
Changes to Core Features: