Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional prop to metadata section #420

Merged

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Sep 1, 2023

Committer Notes

Added prop to the top-level metadata. This may be a possible solution to issue #397.

Also fixed a few small editorial issues in documentation.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@wendellpiez
Copy link
Collaborator

Cool. thanks @david-waltermire-nist

So I just want it on the record I'm not actually entirely comfortable with the 'oscalization' of Metaschema e.g. the entire notion of props in this context. I'm willing to try it out, but I wonder if for v2.0 we can revisit. By that point maybe some of the props could become first-class elements?

Props are definitely good for playing with. 🎺

wendellpiez
wendellpiez previously approved these changes Oct 19, 2023
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially, I think the common noun is "metaschema" for a single instance of Metaschema, alternatively "Metaschema module". Keeping in mind that module (as per the docs) means the composite not the bare unprocessed file before importing, that is the logical 'thing' that becomes a catalog model, and none of the files that compose that thing. The proper noun, "Metaschema", refers to a technology, not an instance.

I suggest the same for Metapath - "Metapath" is a technology, whereas "Metapath expression" or "Metapath path" (for those that are paths) or "metapath" (albeit confusingly) all refer to instances (strings that conform to the Metapath grammar).

What do you think? (Not a blocking request assuming we can also rectify later.)

@david-waltermire david-waltermire merged commit 211dcfc into usnistgov:develop Nov 10, 2023
3 checks passed
@david-waltermire david-waltermire deleted the issue397-metadata-prop branch November 10, 2023 08:41
david-waltermire added a commit that referenced this pull request Jan 4, 2024
* Added prop to the top-level metadata. Also fixed a few small editorial issues in documentation.
* Feature integer indexes (#442)

* Refactoring index naming to use more concise and consistent attribute names.

* Reducing verbosity of index names.

* Staging changes for v1.0.0 (#418)

* Removed support for collapsible. Resolves #354 (#405)
* Adjusting data types in test for greater diversity.

* Updated default extension value

* Fix Metaschema XSD binding to fix #462. (#463)

* Bump sass from 1.66.1 to 1.69.4 (#467)

Bumps [sass](https://github.com/sass/dart-sass) from 1.66.1 to 1.69.4.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.66.1...1.69.4)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 4.1.0 to 4.1.1 (#468)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8ade135...b4ffde6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.4.29 to 8.4.31 (#435)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.29 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.29...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump autoprefixer from 10.4.15 to 10.4.16 (#432)

Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.4.15 to 10.4.16.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@10.4.15...10.4.16)

---
updated-dependencies:
- dependency-name: autoprefixer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Apply suggestions from code review

Addressing terminology based on feedback from @wendellpiez.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants