Add connection location #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ususdei
requested changes
May 25, 2024
Comment on lines
+30
to
+31
| parser.add_argument('--connection', '-c', default='keepassxc.key', | ||
| help='basename of the KeepassXC connection file') |
There was a problem hiding this comment.
I like the feature, just not the name.
connection is too generic here, I don't want to burn that name. It actually is the associationkeyfilename which, admittedly, isn't a very handy name, but still better than connection.
What do you think?
Comment on lines
+157
to
+158
| self.connection = connection | ||
| self.encrypted_connection = connection + '.gpg' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two keepassxc databases, and need to connect to and use both. I have
keybindings that go to one or the other, but I needed to specify a different
store location for the connection key. That is what this PR does.