Skip to content

Configure internal_address_config on httpConnectionManager #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

mmcgarr
Copy link
Contributor

@mmcgarr mmcgarr commented Feb 24, 2025

Adding a new flag --internal-cidr-ranges which sets the list of cidr ranges to treat as internal addresses. The default value for the option is set to the RFC1918 IP addresses so this should be backwards compatible:

  • 192.168.0.0/16
  • 10.0.0.0/8
  • 172.16.0.0/12

envoy v1.29 logs this warning without this change:

internal_address_config is not configured. The existing default behaviour will trust RFC1918 IP addresses, but this will be changed in next release. Please explictily config internal address config as the migration step.

@mmcgarr mmcgarr marked this pull request as draft February 24, 2025 17:51
@mmcgarr mmcgarr marked this pull request as ready for review February 25, 2025 16:00
@mmcgarr mmcgarr merged commit 45b8f73 into master Feb 25, 2025
6 checks passed
@mmcgarr mmcgarr deleted the airship-4307/configure-internal-address-config branch February 25, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants