Remove Index/MutIndex impl requirement from mem trait #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrbutani
requested changes
May 29, 2022
Member
There was a problem hiding this comment.
This looks good!
I think you can also drop the Index/IndexMut impl from MemoryStub.
|
|
||
| // Changes written with commit_page persist when reset is called. | ||
| // Changes written with write_word must not. | ||
| pub trait Memory: Index<Addr, Output = Word> + IndexMut<Addr, Output = Word> { |
Member
There was a problem hiding this comment.
Suggested change
| pub trait Memory: Index<Addr, Output = Word> + IndexMut<Addr, Output = Word> { | |
| pub trait Memory { |
Comment on lines
+42
to
+46
|
|
||
| fn read_word(&self, addr: Addr) -> Word{0 as u16} | ||
|
|
||
| fn write_word(&mut self, addr: Addr, word: Word){} | ||
|
|
Member
There was a problem hiding this comment.
This is technically a change in behavior from the defaulted read_word/write_word on MemoryStub which would return your last write but that's fine; I don't think we were relying on this anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.