Skip to content

Add bin/oct/hex literals#23

Open
CharlesAverill wants to merge 2 commits intomainfrom
base_literals
Open

Add bin/oct/hex literals#23
CharlesAverill wants to merge 2 commits intomainfrom
base_literals

Conversation

@CharlesAverill
Copy link
Contributor

@CharlesAverill CharlesAverill commented Nov 3, 2023

Fixes #20 and #21

  • Hex literals start with '0x'
  • Bin literals start with '0b'
  • Oct literals start with '0' (following gnu-mips-as convention)

@CharlesAverill CharlesAverill added the enhancement New feature or request label Nov 3, 2023
@CharlesAverill CharlesAverill self-assigned this Nov 3, 2023
qwe-q
qwe-q reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@qwe-q qwe-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll ask John Cole if Octal should be supported this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qwe-q qwe-q qwe-q left review comments

@CowTipper989 CowTipper989 CowTipper989 approved these changes

@hkwheat hkwheat hkwheat approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees

@CharlesAverill CharlesAverill

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

name-as does not support hexadecimal immediates

4 participants

@CharlesAverill @CowTipper989 @qwe-q @hkwheat