Update #23
Merged
Update #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarota
reviewed
Apr 19, 2024
context.go
Outdated
Comment on lines
72
to
76
| return r.Form.Get("castle_request_token") | ||
| if tkn := r.Form.Get("castle_request_token"); tkn != "" { | ||
| return tkn | ||
| } | ||
|
|
||
| return r.Form.Get("castle-request-token") |
There was a problem hiding this comment.
I don't think I get this; doesn't the return statement at the end also capture the if block above? 🤔
There was a problem hiding this comment.
The parameters are slightly different between the two calls.
Alternatively, you could define these as validTokenNames := []string{...} & then loop over each checking them?
Jarota
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
castle-request-token