Make sync.Maps safe for go routines #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ffilippopoulos
commented
Jul 29, 2024
ffilippopoulos
commented
- Copy nodeResources data before manipulating to avoid map concurrent modification issues
- Use pointers to follow structures Go common practice and be lighter in memory when deep copying.
- Copy nodeResources data before manipulating to avoid map concurrent modification issues - Use pointers to follow structures Go common practice and be lighter in memory when deep copying.
ffilippopoulos
force-pushed
the
thread-safe-sync-maps
branch
from
7504987 to
a2b5152
Compare
asiyani
approved these changes
Jul 29, 2024
george-angel
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.